New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defining 'can' missing. setting it as a dependancy #674

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
@Psykoral
Contributor

Psykoral commented Jan 17, 2014

no longer relying on the global namespaced 'can'. As noted in Issue #673

Psykoral added some commits Jan 17, 2014

defining 'can' as a dependancy
no longer relying on the global namespaced 'can'. As noted in Issue #673
defining 'can' as a dependancy
no longer relying on the global namespaced 'can'. As noted in Issue #673
@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Jan 17, 2014

Contributor

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated

not sure it actually had an error as much as it just timed out. Can't seem to figure out how to make it try another build.

Contributor

Psykoral commented Jan 17, 2014

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated

not sure it actually had an error as much as it just timed out. Can't seem to figure out how to make it try another build.

Psykoral added some commits Jan 17, 2014

closing unterminated statements
Hoping this will also generate a new build since the last one timed out.
@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 17, 2014

Contributor

Looks like test/dojo.html broke. Try that page in your browser and see what happens.

Contributor

justinbmeyer commented Jan 17, 2014

Looks like test/dojo.html broke. Try that page in your browser and see what happens.

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Jan 17, 2014

Contributor

Yeah just noticed that too. I'm just leaving work, going to head home and run these tests again and track it down.

Contributor

Psykoral commented Jan 17, 2014

Yeah just noticed that too. I'm just leaving work, going to head home and run these tests again and track it down.

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Jan 17, 2014

Contributor

OK, got it. Looks like hashchange() was actually specifically built to use globals, so I'll pass on that one for the time being. The greater fix was for elements and setting the scope for the 'can' name space. Please review this when you get a chance and let me know if you have any concerns.

Contributor

Psykoral commented Jan 17, 2014

OK, got it. Looks like hashchange() was actually specifically built to use globals, so I'll pass on that one for the time being. The greater fix was for elements and setting the scope for the 'can' name space. Please review this when you get a chance and let me know if you have any concerns.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Jan 17, 2014

Contributor

Cool, thank you! I think we can get this in 2.1 (there were some other AMD related changes that were suggested as well). It would be nice if we could also run the tests with GLOBALCAN disabled to see if anything fails.

Contributor

daffl commented Jan 17, 2014

Cool, thank you! I think we can get this in 2.1 (there were some other AMD related changes that were suggested as well). It would be nice if we could also run the tests with GLOBALCAN disabled to see if anything fails.

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Jan 17, 2014

Contributor

Ah. Is there an ETA on 2.1 yet? I was hoping to get this fixed soon because "we" have an application that's depending on this fix. If I need to I can change our configs to bower it in from my Fork. But if there's any chance at just a small patch for this, it would help "us" greatly :c)

Contributor

Psykoral commented Jan 17, 2014

Ah. Is there an ETA on 2.1 yet? I was hoping to get this fixed soon because "we" have an application that's depending on this fix. If I need to I can change our configs to bower it in from my Fork. But if there's any chance at just a small patch for this, it would help "us" greatly :c)

@shcarrico

This comment has been minimized.

Show comment
Hide comment
@shcarrico

shcarrico Jan 22, 2014

Contributor

I put these new dependencies in a branch we are running that has many other similar changes in it. I can't take this pull with all the whitespace modifications. Expect to see this in a new point release very shortly.

Contributor

shcarrico commented Jan 22, 2014

I put these new dependencies in a branch we are running that has many other similar changes in it. I can't take this pull with all the whitespace modifications. Expect to see this in a new point release very shortly.

@shcarrico shcarrico closed this Jan 22, 2014

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Jan 22, 2014

Contributor

Yeah, sorry about all that. The biggest (actual) change was in view/elements.js where
-steal(function(){ ... should be...
+steal("can/view", function( can ) {

Thanks for the quick turnaround!

Contributor

Psykoral commented Jan 22, 2014

Yeah, sorry about all that. The biggest (actual) change was in view/elements.js where
-steal(function(){ ... should be...
+steal("can/view", function( can ) {

Thanks for the quick turnaround!

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jan 30, 2014

Contributor

So this is closed, but no commits are referenced. @shcarrico can you point this thread to where these changes happened?

Contributor

justinbmeyer commented Jan 30, 2014

So this is closed, but no commits are referenced. @shcarrico can you point this thread to where these changes happened?

@Psykoral

This comment has been minimized.

Show comment
Hide comment
@Psykoral

Psykoral Feb 25, 2014

Contributor

Edit: looks like it was fixed in 2.0.5. Thanks guys!

Contributor

Psykoral commented Feb 25, 2014

Edit: looks like it was fixed in 2.0.5. Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment