New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote the pushstate #652 test for stability purposes #699

Merged
merged 4 commits into from Jan 23, 2014

Conversation

Projects
None yet
1 participant
@andykant
Contributor

andykant commented Jan 23, 2014

The test for pushstate was too inconsistent in its result (often failed when running in Travis-CI). This rewrites the test so that it only tests the unique cases as well as that it doesn't rely on any timing race conditions.

@andykant

This comment has been minimized.

Show comment
Hide comment
@andykant

andykant Jan 23, 2014

Contributor

This is ready to merge pending some external changes involving test running.

Contributor

andykant commented Jan 23, 2014

This is ready to merge pending some external changes involving test running.

andykant added a commit that referenced this pull request Jan 23, 2014

Merge pull request #699 from bitovi/new_pushstate_test
Rewrote the pushstate #652 test for stability purposes

@andykant andykant merged commit 9f49050 into master Jan 23, 2014

1 check passed

default The Travis CI build passed
Details

@andykant andykant deleted the new_pushstate_test branch Jan 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment