Changing can.Control.route to match pushstate (#612) #700

merged 4 commits into from Jan 23, 2014


None yet
2 participants

andykant commented Jan 23, 2014

When using can.Control.route with pushstate.js the events never fire because the selectors don't match those in pushstate.js. This is because before a route is added to can.route.routes it is stripped of any preceding forward slash. I've added the same check on line 9. This causes routes to match and controller events fire. This shouldn't affect routes using #! since those routes won't start with a forward slash.

See #612 for more information.

andykant added a commit that referenced this pull request Jan 23, 2014

Merge pull request #700 from bitovi/can-control-route_selectors
Changing can.Control.route to match pushstate (#612)

@andykant andykant merged commit 6165fd9 into master Jan 23, 2014

1 check passed

default The Travis CI build passed

@andykant andykant deleted the can-control-route_selectors branch Jan 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment