New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the pushstate #652 test to ensure that it should pass in all libraries and phantomjs #702

Merged
merged 9 commits into from Jan 29, 2014

Conversation

Projects
None yet
3 participants
@andykant
Contributor

andykant commented Jan 24, 2014

This test used to have timing issues but has had a lot of cross-browser and cross-library issues.

@stevenvachon

This comment has been minimized.

Show comment
Hide comment
@stevenvachon

stevenvachon Jan 24, 2014

Contributor

Would it be possible to squash these into one so that I could see how you solved the issue? If not, that's cool

Contributor

stevenvachon commented Jan 24, 2014

Would it be possible to squash these into one so that I could see how you solved the issue? If not, that's cool

@andykant

This comment has been minimized.

Show comment
Hide comment
@andykant

andykant Jan 24, 2014

Contributor

@stevenvachon If you click the Files Changed tab, it'll give you a diff that summarizes the entire pull request. (and then click View if you want to see the full file)

Also, the issue may or not be solved, we're doing cross browser and cross library testing and stuff keeps popping up. :)

Contributor

andykant commented Jan 24, 2014

@stevenvachon If you click the Files Changed tab, it'll give you a diff that summarizes the entire pull request. (and then click View if you want to see the full file)

Also, the issue may or not be solved, we're doing cross browser and cross library testing and stuff keeps popping up. :)

@stevenvachon

This comment has been minimized.

Show comment
Hide comment
@stevenvachon

stevenvachon Jan 24, 2014

Contributor

Oh cool! I had no idea about that.

Writing this test was pretty difficult and time consuming for me and I even did cross-library tests (grunt test) which passed. I didn't test any non-webkit browsers, though. Fixing the bug was actually easier than writing the unit test, heheh

Contributor

stevenvachon commented Jan 24, 2014

Oh cool! I had no idea about that.

Writing this test was pretty difficult and time consuming for me and I even did cross-library tests (grunt test) which passed. I didn't test any non-webkit browsers, though. Fixing the bug was actually easier than writing the unit test, heheh

daffl added a commit that referenced this pull request Jan 29, 2014

Merge pull request #702 from bitovi/2.0.5_test_fixes
Fixed the pushstate #652 test to ensure that it should pass in all libraries and phantomjs

@daffl daffl merged commit 9e193d2 into master Jan 29, 2014

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the 2.0.5_test_fixes branch Jan 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment