New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#773: Fixing date compare logic in can.Object.same. #775

Merged
merged 3 commits into from Mar 13, 2014

Conversation

Projects
None yet
2 participants
@dispatchrabbi
Contributor

dispatchrabbi commented Mar 11, 2014

Here's the fiddle that demonstrates the issue: http://jsfiddle.net/bu9sd/1/

Closes #773

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Mar 11, 2014

Contributor

Shouldn't that also compare the time value to fix it right? Because new Date() === new Data() // -> false

Contributor

daffl commented on util/object/object.js in 549ea7c Mar 11, 2014

Shouldn't that also compare the time value to fix it right? Because new Date() === new Data() // -> false

@dispatchrabbi

This comment has been minimized.

Show comment
Hide comment
@dispatchrabbi

dispatchrabbi Mar 11, 2014

Contributor

@daffl I agree, but @justinbmeyer feels like that would be a breaking API change, so it should wait for 3.0. There is a workaround using the compares param.

Contributor

dispatchrabbi commented Mar 11, 2014

@daffl I agree, but @justinbmeyer feels like that would be a breaking API change, so it should wait for 3.0. There is a workaround using the compares param.

@daffl daffl added this to the 2.0.6 milestone Mar 12, 2014

daffl added a commit that referenced this pull request Mar 13, 2014

Merge pull request #775 from bitovi/773-same-date-logic
#773: Fixing date compare logic in can.Object.same.

@daffl daffl merged commit 991daa4 into master Mar 13, 2014

1 check passed

default The Travis CI build passed
Details

@daffl daffl deleted the 773-same-date-logic branch Mar 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment