New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can.Map.define #913

Merged
merged 16 commits into from May 1, 2014

Conversation

Projects
None yet
3 participants
@moschel
Contributor

moschel commented Apr 29, 2014

Finished off the remaining docs, functionality, and tests for the map/define plugin #819. Also added deprecation warnings for map/setter and map/attributes (in the code and the docs). Tests are passing, should be ready to merge.

@ccummings ccummings added this to the 2.1.0 milestone Apr 29, 2014

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer May 1, 2014

Contributor

@moschel this gets called twice.

Contributor

justinbmeyer commented on map/attributes/attributes.js in 0196a5f May 1, 2014

@moschel this gets called twice.

@moschel moschel merged commit 8073bed into minor May 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the map-define branch May 30, 2014

@justinbmeyer

This comment has been minimized.

Show comment
Hide comment
@justinbmeyer

justinbmeyer Jun 1, 2015

Contributor

This gets called a million times. Moving it.

Contributor

justinbmeyer commented on map/setter/setter.js in 0196a5f Jun 1, 2015

This gets called a million times. Moving it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment