New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to mix can.event into can.Controls safely #982

Merged
merged 2 commits into from May 16, 2014

Conversation

Projects
None yet
2 participants
@andykant
Contributor

andykant commented May 9, 2014

When using the new can/event mixin, it can cause conflicts with can.Control-based classes due to duplicate methods can.Control#on and can.Control#off. (#981)

This syntax used to result in no event handlers being bound, but this pull request fixes that:

var MyControl = can.Control.extend(can.extend({}, can.event, {
  " click": function() { /* didn't fire before, but does now */ }
}));

@ccummings ccummings added this to the 2.1.1 milestone May 15, 2014

@ccummings ccummings added the Bug label May 15, 2014

ccummings added a commit that referenced this pull request May 16, 2014

Merge pull request #982 from bitovi/can-control-event
Adding ability to mix can.event into can.Controls safely

@ccummings ccummings merged commit 7f3ef94 into minor May 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

ccummings added a commit that referenced this pull request May 16, 2014

Revert "Merge pull request #982 from bitovi/can-control-event"
This reverts commit 7f3ef94, reversing
changes made to f6abe2a.

@ccummings ccummings referenced this pull request May 16, 2014

Merged

Can control event #993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment