deprecation notice number 6 #145

Merged
merged 2 commits into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
Collaborator

sergiusens commented Nov 3, 2017

Added the notice for dn6 and fixed the indexing

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

deprecation notice number 6
Added the notice for dn6 and fixed the indexing

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Looking good! I have a few suggestions inline. Thanks for this!

deprecation-notices/dn6.md
+
+_introduced in snapcraft 2.35_
+
+With the introduction of vesion 2.35, `snapcraft snap` has been reserved as a step
@kyrofa

kyrofa Nov 3, 2017

Collaborator

There's a typo in "version" here, but this is a redundant sentence anyway, and doesn't follow the pattern of the other guides. Since we say right above "introduced in v2.35," I say we rephrase this to:

The `snap` command originally served two purposes:

1. `snapcraft snap` walked through the entire lifecycle for each part of the project (pull, build, stage, and prime) before finally creating the snap, and
2. `snapcraft snap <directory>` simply created a snap of the provided directory (without involving the lifecycle at all).

This ended up being confusing [...]
deprecation-notices/dn6.md
+
+The new command `pack` is much more explicit in that snapcraft is just focusing
+on assembling the final snap from a valid layout for a given directory, such that
+the new way to create a snap from a directory has the following syntax:
@kyrofa

kyrofa Nov 3, 2017

Collaborator

I would rephrase slightly: "[...] from a valid layout for a given directory. The new way to create [...]".

+- [DN3](/deprecation-notices/dn3) -- Assets in `setup/gui` should now be placed in `snap/gui`.
@kyrofa

kyrofa Nov 3, 2017

Collaborator

Good catch! We haven't been updating this, obviously.

kyrofa approved these changes Nov 3, 2017

Word wrapping is off now, but that's not very important, and the content looks good!

caldav approved these changes Nov 3, 2017

👍

@caldav caldav merged commit fea30bf into canonical-docs:master Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment