Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluentd page #132

Merged
merged 3 commits into from Oct 11, 2019

Conversation

@evilnick
Copy link
Contributor

commented Oct 9, 2019

No description provided.

@webteam-app

This comment has been minimized.

@evilnick evilnick marked this pull request as ready for review Oct 9, 2019
@evilnick evilnick requested a review from ktsakalozos Oct 9, 2019
Copy link
Contributor

left a comment

LGTM on this PR

Only one comment on the left-side index. I think it would look much better if we removed the top level "Docs" and under the "Addons" we have one entry per addon.

@pmahnke pmahnke added the Blocked ⛔ label Oct 11, 2019
@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

Yes, we will have to rework the navigation anyhow, though this doesn't affect this pr

@evilnick evilnick removed the Blocked ⛔ label Oct 11, 2019
@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

@ktsakalozos can you change the appropriate labels when you review things? remove the 'x needed' and replace with the 'x +1' ones

@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

thx!

@evilnick evilnick merged commit ebe4ea7 into canonical-web-and-design:master Oct 11, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
ci/circleci: lint-nginx Your tests passed on CircleCI!
Details
ci/circleci: lint-scss Your tests passed on CircleCI!
Details
ci/circleci: test-site Your tests passed on CircleCI!
Details
@evilnick evilnick deleted the evilnick:fluentd branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.