Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a local certification file #75

Merged

Conversation

Projects
None yet
3 participants
@ktsakalozos
Copy link
Contributor

commented May 2, 2019

The link to the certification badge is broken. With this PR we pull in a certification badge and use that.

@webteam-app

This comment has been minimized.

Copy link

commented May 2, 2019

User is not a collaborator of this repo. Please start demo manually.

@webteam-app

This comment has been minimized.

@evilnick
Copy link
Contributor

left a comment

Okay I can see what the original problem was, but there are a number of issues with this fix:

  • there is already an image in the asset server for the certified kubernetes badge
  • It breaks the layout somewhat at this size
  • Because the intro text is shor, it also doesn't really line up with anything

I'll take a go at fixing

Update index.md
I think this works better, but happy to welcome other opinions
@webteam-app

This comment has been minimized.

@evilnick

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@ktsakalozos I don't seem to be easily able to delete the graphic file you added, so if you could remove that from the PR and take a look at the demo

@ktsakalozos

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

LGTM @evilnick. We can also just remove the badge since we have it in the landing page on microk8s.io.

@evilnick

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

thats true, but I guess that some places may link direct to the docs. This looks fine to me.

@evilnick evilnick merged commit 790cf25 into canonical-web-and-design:master May 2, 2019

4 checks passed

WIP Ready for review
Details
ci/circleci: lint-nginx Your tests passed on CircleCI!
Details
ci/circleci: lint-scss Your tests passed on CircleCI!
Details
ci/circleci: test-site Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.