Add 3rd party store links #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting demo at: https://snapcraft-io-canonical-web-and-design-pr-2434.run.demo.haus/ |
|
plex android should be https://play.google.com/store/apps/details?id=com.plexapp.android |
solazio
force-pushed
the
1186-implement-links-to-3rd-party-stores
branch
from
da6b018
to
40c4a3a
Compare
Lukewh
reviewed
Jan 14, 2020
templates/store/snap-details.html
Outdated
| {% if request.path in ["/vlc", "/standard-notes", "/plexmediaserver"] %} | ||
| <h4>Companion apps</h4> | ||
| <ul class="p-list"> | ||
| <li class="p-list__item u-no-padding--left"><a href="{% if request.path == '/vlc' %}https://apps.apple.com/us/app/vlc-for-mobile/id650377962{% elif request.path == '/standard-notes' %}https://apps.apple.com/gb/app/standard-notes/id1285392450{% elif request.path == '/plexmediaserver' %}https://apps.apple.com/gb/app/plex-movies-tv-music-more/id383457673{% endif %}" onclick="dataLayer.push({'event' : 'GAEvent', 'eventCategory' : '3rd Party Store Link', 'eventAction' : 'App Store Link ', 'eventLabel' : 'App Store Link', 'eventValue' : undefined });"><img |
There was a problem hiding this comment.
Could "eventValue" maybe be the snap name? Would that be useful? Not sure
Also perhaps split these lines as they get pretty long
Lukewh
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
solazio
force-pushed
the
1186-implement-links-to-3rd-party-stores
branch
from
40c4a3a
to
84df4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
/vlc,/standard-notes,/plexmediaserverIssue / Card
Fixes https://github.com/canonical-web-and-design/snap-squad/issues/1186
QA
Pull the branch
Run the site using the command
./runView the site locally in your web browser at: http://0.0.0.0:8004/snap_name
Run through the following QA steps
Make sure you see the 3rd party app store buttons on
/vlc,/standard-notes,/plexmediaserverand not other snap details pageshttps://snapcraft-io-canonical-web-and-design-pr-2434.run.demo.haus/vlc
https://snapcraft-io-canonical-web-and-design-pr-2434.run.demo.haus/standard-notes
https://snapcraft-io-canonical-web-and-design-pr-2434.run.demo.haus/plexmediaserver