Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8sdocs - remove conjure up #5660

Merged

Conversation

@evilnick
Copy link
Contributor

commented Aug 8, 2019

Done

Rewritten Quickstart page
Rewritten Install page
slight change to operations page

These changes remove references to conjure-up as an installer.

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8001/
  • Run through the following QA steps
@webteam-app

This comment has been minimized.

@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

There is definitely an issue with

  • the width of the navigation (when did entries there stop wrapping?)
  • I'm not sure if that is also the cause of everything no longer lining up in the content (i.e. numbers/headings on steps in Quickstart page)

any suggestions welcome

@pmahnke

pmahnke approved these changes Aug 9, 2019

Copy link
Contributor

left a comment

seems fine.

@pmahnke pmahnke merged commit f5784b2 into canonical-web-and-design:master Aug 9, 2019

5 checks passed

WIP Ready for review
Details
ci/circleci: linkchecker Your tests passed on CircleCI!
Details
ci/circleci: lint-python Your tests passed on CircleCI!
Details
ci/circleci: lint-scss Your tests passed on CircleCI!
Details
ci/circleci: test-python Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.