Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback links to K8s docs #5875

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@evilnick
Copy link
Contributor

commented Oct 2, 2019

Done

  • Add a feedback link to the bottom of every page
  • update crash-reporting section

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8001/
  • Run through the following QA steps

Feedback section should look something like this:

image

evilnick added 2 commits Oct 2, 2019
@webteam-app

This comment has been minimized.

Copy link
Contributor

left a comment

LGTM 👍

@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

thaks @sowasred2012. Can you leave an approving review so I can merge?

Copy link
Contributor

left a comment

@evilnick apologies, thought I had! Fixed

@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

thanks!

@evilnick evilnick merged commit ea7e49f into canonical-web-and-design:master Oct 7, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
ci/circleci: linkchecker Your tests passed on CircleCI!
Details
ci/circleci: lint-python Your tests passed on CircleCI!
Details
ci/circleci: lint-scss Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.