Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use linkchecker installed on older ubuntu LTS #3681

Merged
merged 1 commit into from Apr 2, 2021

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Apr 1, 2021

Done

Revert installing linkchecker via pip to package on ubuntu@18.04 due to building issues.
Created #3682 to investigate why it was failing and try to find a different way to fix it.

QA

  • All CI checks should pass, including linkchecker

@webteam-app
Copy link

Demo starting at https://vanilla-framework-3681.demos.haus

@bartaz bartaz changed the title Try linkchecker installed on older ubuntu LTS WIP: Try linkchecker installed on older ubuntu LTS Apr 1, 2021
@bartaz bartaz marked this pull request as ready for review April 1, 2021 15:42
@bartaz bartaz changed the title WIP: Try linkchecker installed on older ubuntu LTS Use linkchecker installed on older ubuntu LTS Apr 1, 2021
Copy link
Contributor

@sowasred2012 sowasred2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit 1d47892 into canonical:master Apr 2, 2021
@bartaz bartaz deleted the linkchecker-install branch April 2, 2021 06:24
@anthonydillon
Copy link
Contributor

You could also leave it on latest and pip install.

@bartaz
Copy link
Contributor Author

bartaz commented Apr 2, 2021

You could also leave it on latest and pip install.

@anthonydillon That's exactly what we used to have and needed to change because it started failing yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants