Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth page for Kubernetes docs #5099

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
3 participants
@evilnick
Copy link
Contributor

commented May 7, 2019

Done

Added new page to navigation.yaml and docs nav
Added /kubernetes/docs/auth page

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8001/
  • Run through the following QA steps
  • Agree that it is great
@webteam-app

This comment has been minimized.

@pmahnke

pmahnke approved these changes May 7, 2019

Copy link
Contributor

left a comment

lgtm 👍

@pmahnke pmahnke merged commit 038c86b into canonical-web-and-design:master May 7, 2019

5 checks passed

WIP Ready for review
Details
ci/circleci: linkchecker Your tests passed on CircleCI!
Details
ci/circleci: lint-python Your tests passed on CircleCI!
Details
ci/circleci: lint-scss Your tests passed on CircleCI!
Details
ci/circleci: test-python Your tests passed on CircleCI!
Details
@evilnick

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.