Permalink
Browse files

Merge pull request #13 from nottrobin/contributing-approval

CONTRIBUTING.md: Rules for approving pull requests
  • Loading branch information...
nottrobin committed Mar 7, 2017
2 parents bfc05a6 + 12cb520 commit a6b93f6d3e143d3c37d1eb561740722282d37ed4
Showing with 12 additions and 0 deletions.
  1. +12 −0 CONTRIBUTING.md
@@ -7,3 +7,15 @@ Anyone is welcome to suggest improvements in one of two ways:

- Start a discussion by submitting [a new issue](https://github.com/ubuntudesign/webteam-practices/issues/new)
- Suggest a change by submitting a pull request ([how?](https://help.github.com/articles/about-pull-requests/))

Approving a pull request
---

Before a pull request is approved and merged:

- A reasonable effort should be made to bring it to the attention of the whole team
- It should also have been :+1:d by at least 2 team members
- It should have been open for at least 24 hours

Once it is merged, it should be brought up in the next relevant team meeting to ensure the whole team is aware of the change.

0 comments on commit a6b93f6

Please sign in to comment.