Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: fix autoinstall and run file #1428

Merged
merged 1 commit into from Sep 21, 2022
Merged

kernel: fix autoinstall and run file #1428

merged 1 commit into from Sep 21, 2022

Conversation

dbungert
Copy link
Collaborator

@dbungert dbungert commented Sep 20, 2022 •
edited

No description provided.

@dbungert dbungert marked this pull request as ready for review September 20, 2022 16:46
ogayot
ogayot approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@ogayot ogayot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for getting rid of the if flavor is None: package = 'generic' block. It was confusing.

@dbungert dbungert merged commit e16f812 into canonical:main Sep 21, 2022
@dbungert dbungert deleted the lp-1989353-ai-vs-kernel branch September 21, 2022 13:51
@dbungert
Copy link
Collaborator Author

Thanks for getting rid of the if flavor is None: package = 'generic' block. It was confusing.

Thanks! Yes I read that about a dozen times looking for pitfalls before concluding that it was indeed redundant.

@dbungert dbungert mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogayot ogayot ogayot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dbungert @ogayot