apport-retrace: Do not drop environment variables when calling GDB #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `lay src` in the GDB session opened by `apport-retrace` fails with: ``` (gdb) lay src Cannot enable the TUI: error opening terminal [TERM=<unset>] ``` This is caused by calling `gdb` with a minimal environment that does not include `TERM`. Keep the minimal environment for `Report.add_gdb_info` (for not translating the gdb output), but use the full environment when an interactive GDB session is started via `apport-retrace`. Bug: https://launchpad.net/bugs/2012374 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 81.95% 81.97% +0.01%
==========================================
Files 87 87
Lines 18197 18198 +1
==========================================
+ Hits 14914 14917 +3
+ Misses 3283 3281 -2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
schopin-pro
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
lay srcin the GDB session opened byapport-retracefails with:This is caused by calling
gdbwith a minimal environment that does not includeTERM.Keep the minimal environment for
Report.add_gdb_info(for not translating the gdb output), but use the full environment when an interactive GDB session is started viaapport-retrace.Bug: https://launchpad.net/bugs/2012374