fix(apport-kde): Fix showing progress in the progress bar #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Commit 57c674a tries to fix following crash: ``` $ ubuntu-bug dolphin Traceback (most recent call last): File "/usr/share/apport/apport-kde", line 532, in <module> sys.exit(UserInterface.run_argv()) File "/usr/lib/python3/dist-packages/apport/ui.py", line 717, in run_argv return self.run_report_bug() File "/usr/lib/python3/dist-packages/apport/ui.py", line 558, in run_report_bug self.file_report() File "/usr/lib/python3/dist-packages/apport/ui.py", line 1391, in file_report self.ui_set_upload_progress(__upload_progress) File "/usr/share/apport/apport-kde", line 442, in ui_set_upload_progress self.progress.set(progress) File "/usr/share/apport/apport-kde", line 129, in set progress.setValue(value * 1000) TypeError: setValue(self, int): argument 1 has unexpected type 'float' ``` The value is a float between 0 and 1. Converting the value to integer before multiplying by 1000 result only two values for the progress bar: 0% and 100%. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 81.95% 82.00% +0.04%
==========================================
Files 87 87
Lines 18197 18206 +9
==========================================
+ Hits 14914 14929 +15
+ Misses 3283 3277 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks a lot for this fix! |
schopin-pro
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 57c674a tries to fix following crash:
The value is a float between 0 and 1. Converting the value to integer before multiplying by 1000 result only two values for the progress bar: 0% and 100%.
See https://launchpad.net/bugs/1876068 for the origin.