tests: Fix path for installed apport-cli and fix test_run_crash_kernel on Azure #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 79.46% 79.70% +0.24%
==========================================
Files 77 77
Lines 17213 17215 +2
==========================================
+ Hits 13678 13721 +43
+ Misses 3535 3494 -41
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Running the CLI UI tests against the install Apport fails:
```
Traceback (most recent call last):
[...]
File "tests/integration/test_ui_cli.py", line 25, in <module>
apport_cli = import_module_from_file(apport_cli_path)
File "tests/helper.py", line 48, in import_module_from_file
spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 879, in exec_module
File "<frozen importlib._bootstrap_external>", line 1016, in get_code
File "<frozen importlib._bootstrap_external>", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/apport/apport-cli'
```
The CLI is installed in `/usr/bin/apport-cli`.
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
The UI integration test case `test_run_crash_kernel` fails on Azure:
```
> self.assertEqual(
self.ui.opened_url,
"http://%s.bugs.example.com/%i"
% (src_pkg, self.ui.crashdb.latest_id()),
)
E AssertionError: 'http://linux-signed-azure.bugs.example.com/5' != 'http://linux-signed.bugs.example.com/5'
E - http://linux-signed-azure.bugs.example.com/5
E ? ------
E + http://linux-signed.bugs.example.com/5
tests/integration/test_ui.py:1574: AssertionError
```
The kernel source package is named `linux-signed-azure` on Azure.
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Ubuntu's autopkgtest runs the unit and integration tests against the installed system. Test this scenario in the CI as well. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
bdrung
force-pushed
the
unit-test-installed
branch
from
2000830
to
4fa4c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the CLI UI tests against the install Apport fails:
The CLI is installed in
/usr/bin/apport-cli.The UI integration test case
test_run_crash_kernelfails on Azure:The kernel source package is named
linux-signed-azureon Azure.Ubuntu's autopkgtest runs the unit and integration tests against the installed system. Test this scenario in the CI as well.