fix: Catch UnicodeDecodeError on a malformed problem report #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apport-unpack will crash when passing a binary file that is not valid
UTF-8:
```
$ apport-unpack /bin/ls unpack
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/problem_report.py", line 175, in load
(key, value) = line.split(b":", 1)
^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 2, got 1)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/bin/apport-unpack", line 91, in <module>
main()
File "/usr/bin/apport-unpack", line 67, in main
pr = load_report(args.report)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/bin/apport-unpack", line 47, in load_report
pr.load(f, binary=False)
File "/usr/lib/python3/dist-packages/problem_report.py", line 178, in load
f"Malformed problem report: Line {line.decode()!r}"
^^^^^^^^^^^^^
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc0 in position 24: invalid start byte
```
When wrapping the `ValueError` into an `MalformedProblemReport`, do not
expect the causing line to be valid UTF-8. Replace the invalid
characters with backslashed escape sequences.
Bug: https://launchpad.net/bugs/1996040
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 80.13% 80.14%
=======================================
Files 81 81
Lines 17583 17588 +5
=======================================
+ Hits 14091 14096 +5
Misses 3492 3492
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apport-unpack will crash when passing a binary file that is not valid UTF-8:
When wrapping the
ValueErrorinto anMalformedProblemReport, do not expect the causing line to be valid UTF-8. Replace the invalid characters with backslashed escape sequences.Bug: https://launchpad.net/bugs/1996040