-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-init / nplan - missing bond mode miimon xmit_hash_policy #2888
Comments
Launchpad user Dimitri John Ledkov(xnox) wrote on 2017-05-13T00:10:26.240366+00:00 In test_configdrive.py it specifies bond_mode as "4", whereas my configdrive specifies it as 802.3ad |
Launchpad user Dimitri John Ledkov(xnox) wrote on 2017-05-13T00:35:00.786429+00:00 After fixing the tools/net-convert, i get the internal state. It seems like - vs _ are inconsistent. SHould the cloud-init's interval v1 network state use dashes or underscores? Internal state http://paste.ubuntu.com/24564073/ |
Launchpad user Dimitri John Ledkov(xnox) wrote on 2017-05-13T00:45:00.380649+00:00 Somehow it seems to me the network_data.json is not correctly parsed and used in the renderers to set these values. |
Launchpad user Launchpad Janitor(janitor) wrote on 2017-05-26T20:12:30.745223+00:00 This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-0ubuntu1 cloud-init (0.7.9-153-g16a7302f-0ubuntu1) artful; urgency=medium
-- Scott Moser smoser@ubuntu.com Fri, 26 May 2017 15:11:48 -0400 |
Launchpad user Scott Moser(smoser) wrote on 2017-06-02T15:47:48.871809+00:00 Launchpad attachments: network_data.json from the summary |
Launchpad user Dimitri John Ledkov(xnox) wrote on 2017-06-05T23:15:46.765521+00:00 Is SRU with this change in progress for xenial? |
Launchpad user Brian Murray(brian-murray) wrote on 2017-06-13T18:07:40.269715+00:00 Hello Dimitri, or anyone else affected, Accepted cloud-init into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-153-g16a7302f-0ubuntu1~17.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! |
Launchpad user Brian Murray(brian-murray) wrote on 2017-06-13T18:55:11.390923+00:00 Hello Dimitri, or anyone else affected, Accepted cloud-init into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-153-g16a7302f-0ubuntu1~16.10.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! |
Launchpad user Brian Murray(brian-murray) wrote on 2017-06-13T19:08:43.352358+00:00 Hello Dimitri, or anyone else affected, Accepted cloud-init into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-init/0.7.9-153-g16a7302f-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! |
Launchpad user Chad Smith(chad.smith) wrote on 2017-06-14T01:40:45.546842+00:00 Validated bond parameters are showing up in xenial yakkety and zesty: Internal State Checking 50-cloud-init.yaml --- Internal State Checking 50-cloud-init.yaml --- Internal State Checking 50-cloud-init.yaml --- |
Launchpad user Launchpad Janitor(janitor) wrote on 2017-06-27T15:51:34.880334+00:00 This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-0ubuntu1~17.04.1 cloud-init (0.7.9-153-g16a7302f-0ubuntu1~17.04.1) zesty-proposed; urgency=medium
-- Scott Moser smoser@ubuntu.com Fri, 26 May 2017 16:14:09 -0400 |
Launchpad user Steve Langasek(vorlon) wrote on 2017-06-27T15:52:40.597247+00:00 The verification of the Stable Release Update for cloud-init has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions. |
Launchpad user Launchpad Janitor(janitor) wrote on 2017-06-27T15:54:02.062609+00:00 This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-0ubuntu1~16.10.1 cloud-init (0.7.9-153-g16a7302f-0ubuntu1~16.10.1) yakkety-proposed; urgency=medium
-- Scott Moser smoser@ubuntu.com Fri, 26 May 2017 16:08:21 -0400 |
Launchpad user Launchpad Janitor(janitor) wrote on 2017-06-27T15:54:45.867129+00:00 This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-0ubuntu1~16.04.1 cloud-init (0.7.9-153-g16a7302f-0ubuntu1~16.04.1) xenial-proposed; urgency=medium
-- Scott Moser smoser@ubuntu.com Fri, 26 May 2017 15:58:48 -0400 |
Launchpad user Scott Moser(smoser) wrote on 2017-09-23T02:32:35.058353+00:00 This bug is believed to be fixed in cloud-init in 17.1. If this is still a problem for you, please make a comment and set the state back to New Thank you. |
This bug was originally filed in Launchpad as LP: #1690480
Launchpad details
Launchpad user Dimitri John Ledkov(xnox) wrote on 2017-05-12T23:59:30.041597+00:00
=== Begin SRU Template ===
[Impact]
When rendering netplan output from OpenStack network configuration format
(network_data.json), cloud-init would not correctly represent some
bond attributes. The result is that those attributes are not set as
desired.
[Test Case]
The basic idea below is:
a.) launch an instance with proposed version of cloud-init.
b.) inside instance, get cloud-init's network rendering tool from trunk
c.) run the rendering tool against a config that failed before.
d.) check rendered netplan config to verify it has expected bond attributes.
launch an instance.
$ release=xenial
$ ref=$release-proposed
$ lxc-proposed-snapshot --proposed --publish $release $ref
$ lxc launch $name
$ sleep 10
$ lxc exec $name /bin/bash
get render tool
% wget https://git.launchpad.net/~cloud-init-dev/cloud-init/plain/tools/net-convert.py -O net-convert.py
% wget https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1690480/+attachment/4887940/+files/network_data.json -O network_data.json
% python3 ./net-convert.py
--network-data=network_data.json --kind=network_data.json
--output-kind=netplan
--mac=eth0,a0:36:9f:2d:93:80 --mac=eth1,a0:36:9f:2d:93:81
--directory=out.d
Now see that the 'mii-monitor-interval', 'mode', and
'transmit-hash-policy' are present in output.
% egrep --context=5 '(mii-monitor-interval|mode|transmit-hash-policy)'
out.d/etc/netplan/50-cloud-init.yaml
bond0:
interfaces:
- eth0
- eth1
parameters:
mii-monitor-interval: 100
mode: 802.3ad
transmit-hash-policy: layer3+4
vlans:
bond0.101:
addresses:
- 104.130.20.119/24
id: 101
[Regression Potential]
Fairly low chance for regression. The bond attributes were just not
being written and now they will be.
[Other Info]
Upstream commit at
https://git.launchpad.net/cloud-init/commit/?id=910ed46124e
lxc-proposed-snapshot is
https://git.launchpad.net/~smoser/cloud-init/+git/sru-info/tree/bin/lxc-proposed-snapshot
It publishes an image to lxd with proposed enabled and cloud-init upgraded.
=== End SRU Template ===
Given network-data.json http://paste.ubuntu.com/24561026/
cloud-init generates http://paste.ubuntu.com/24564006/
which is missing
"bond_mode" : "802.3ad",
"bond_miimon" : 100,
"bond_xmit_hash_policy" : "layer3+4"
For the bond specification
As per nplan docs it should be defined as parameters dictionary
https://git.launchpad.net/netplan/tree/doc/netplan.md#n302
mode: 802.3ad
mii-monitor-interval: 100
transmit-hash-policy: layer3+4
The text was updated successfully, but these errors were encountered: