add Openbsd support #147

goneri · 2019-12-29T21:44:08Z

Based on: #62

igalic

🙋

cloudinit/distros/bsd_util.py

raharper

This is quite the large PR! Congrats for putting this all together. I've left quite a few questions and concerns in there. I'm looking forward to adding some more BSD support.

cloudinit/distros/bsd_util.py

cloudinit/distros/netbsd.py

cloudinit/net/openbsd.py

cloudinit/tests/helpers.py

cloudinit/sources/DataSourceNoCloud.py

setup.py

OddBloke · 2020-03-13T16:03:11Z

This requires reconciliation with master, so marking it as wip for now.

goneri · 2020-03-23T20:57:57Z

@OddBloke Could you please remove the wip label? the Pr is ready for review.

OddBloke

Thanks for taking this on, it's much appreciated! At a high level, I think there's a fair amount of duplication between netbsd.py and the new openbsd.py. I'd like us to do some refactoring to reduce that duplication, as it will come back to bite us before too long.

Once that's happened, I'll give this a closer review (I didn't want to ask for changes to the copy/paste'd code, because that's how we end up with subtly out-of-sync parallel implementations).

cloudinit/distros/bsd.py

cloudinit/distros/openbsd.py

cloudinit/net/openbsd.py

OddBloke · 2020-03-24T21:01:50Z

cloudinit/distros/openbsd.py

+            cmd.extend(args)
+
+        pkglist = util.expand_package_list('%s-%s', pkgs)
+        cmd.extend(pkglist)


This still needs to be resolved.

cloudinit/distros/openbsd.py

OddBloke

Thanks for the changes. I've performed a more detailed review now, but overall this looks pretty good!

cloudinit/distros/netbsd.py

cloudinit/net/openbsd.py

cloudinit/sources/DataSourceConfigDrive.py

tools/build-on-openbsd

cloudinit/util.py

cloudinit/sources/DataSourceNoCloud.py

cloudinit/net/openbsd.py

cloudinit/distros/openbsd.py

cloudinit/net/openbsd.py

cloudinit/util.py

OddBloke

Thanks for this iteration, this is looking a lot better! Still a few loose ends I've commented on inline.

cloudinit/distros/netbsd.py

cloudinit/net/__init__.py

cloudinit/net/openbsd.py

cloudinit/net/__init__.py

cloudinit/util.py

OddBloke

This LGTM now, thanks for all your hard work on it!

raharper

Looks good, just a change and a question.

cloudinit/distros/openbsd.py

cloudinit/net/__init__.py

- tested on OpenBSD 6.6 - tested on OpenStack without config drive, and NoCloud with ISO config drive

cloudinit/distros/openbsd.py

cloudinit/net/openbsd.py

raharper

I'd like to clarify expectations on dhcp on all nics, and one name fix up (net -> open).

raharper

OK. Thanks for all the work here. As we discussed in IRC, we'll defer the multi-nic DHCP fix to another PR since it needs to be fixed for all BSD variants.

goneri changed the title ~~Openbsd~~ WIP: Openbsd Dec 29, 2019

igalic reviewed Dec 30, 2019

View reviewed changes

cloudinit/distros/bsd_util.py Outdated Show resolved Hide resolved

goneri force-pushed the openbsd branch from 0534e24 to 38ce52e Compare December 31, 2019 23:00

goneri changed the title ~~WIP: Openbsd~~ add Openbsd support Jan 1, 2020

goneri force-pushed the openbsd branch 2 times, most recently from 1e32253 to b4bf785 Compare January 8, 2020 18:54

goneri force-pushed the openbsd branch from b4bf785 to 8148fe4 Compare January 17, 2020 16:40

raharper requested changes Jan 30, 2020

View reviewed changes

goneri force-pushed the openbsd branch 2 times, most recently from 3002935 to e6f61b3 Compare February 23, 2020 04:16

goneri force-pushed the openbsd branch from e6f61b3 to 6cbaae3 Compare March 11, 2020 12:14

OddBloke self-assigned this Mar 13, 2020

OddBloke added the wip Work in progress, do not land label Mar 13, 2020

goneri force-pushed the openbsd branch 2 times, most recently from 3a93a63 to b15776b Compare March 23, 2020 18:47

OddBloke removed the wip Work in progress, do not land label Mar 23, 2020

goneri force-pushed the openbsd branch from b15776b to d390cf2 Compare March 23, 2020 21:19

OddBloke requested changes Mar 24, 2020

View reviewed changes

goneri force-pushed the openbsd branch 3 times, most recently from 62de1e6 to 788ba0c Compare March 24, 2020 23:14

goneri commented Mar 25, 2020

View reviewed changes

cloudinit/distros/openbsd.py Show resolved Hide resolved

OddBloke requested changes Mar 25, 2020

View reviewed changes

goneri force-pushed the openbsd branch from 788ba0c to cdf4ad0 Compare March 26, 2020 01:14

goneri commented Mar 26, 2020

View reviewed changes

cloudinit/util.py Show resolved Hide resolved

goneri requested review from OddBloke and igalic March 26, 2020 01:18

OddBloke requested changes Mar 26, 2020

View reviewed changes

goneri requested a review from OddBloke March 26, 2020 16:09

OddBloke approved these changes Mar 26, 2020

View reviewed changes

raharper requested changes Mar 26, 2020

View reviewed changes

cloudinit/distros/openbsd.py Show resolved Hide resolved

cloudinit/net/__init__.py Outdated Show resolved Hide resolved

goneri added 10 commits March 26, 2020 14:10

OpenBSD support

a42a4ea

- tested on OpenBSD 6.6 - tested on OpenStack without config drive, and NoCloud with ISO config drive

openbsd: clean up

506142c

netbsd: define _get_pkg_cmd_environ

c39d0a5

OpenBSD, inherite from NetBSD

79e7987

fixes

20995eb

typo

be3538a

find_devs_with_openbsd

18d2c91

update

6c8acb0

some more adjustmenet

f3923fe

raharper comments

bc8bf44

goneri force-pushed the openbsd branch from f4da3a9 to bc8bf44 Compare March 26, 2020 18:11

goneri requested a review from raharper March 26, 2020 18:11

raharper requested changes Mar 26, 2020

View reviewed changes

cloudinit/distros/openbsd.py Show resolved Hide resolved

cloudinit/net/openbsd.py Show resolved Hide resolved

cloudinit/net/openbsd.py Outdated Show resolved Hide resolved

raharper requested changes Mar 26, 2020

View reviewed changes

goneri added 2 commits March 26, 2020 14:57

openbsd: don't default on dhcp

0269490

openbsd handle criteria: TYPE=vfat

87fcbc3

goneri requested a review from raharper March 26, 2020 19:24

raharper approved these changes Mar 26, 2020

View reviewed changes

Merge branch 'master' into openbsd

ab5e7bc

OddBloke merged commit 4403962 into canonical:master Mar 26, 2020

This was referenced May 12, 2023

underscores should be stripped from hostnames generated for apt config #3628

Closed

Release 20.2 #3664

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Openbsd support #147

add Openbsd support #147

goneri commented Dec 29, 2019

igalic left a comment

raharper left a comment

OddBloke commented Mar 13, 2020

goneri commented Mar 23, 2020

OddBloke left a comment

OddBloke Mar 24, 2020

OddBloke left a comment

OddBloke left a comment

OddBloke left a comment

raharper left a comment

raharper left a comment

raharper left a comment

add Openbsd support #147

add Openbsd support #147

Conversation

goneri commented Dec 29, 2019

igalic left a comment

Choose a reason for hiding this comment

raharper left a comment

Choose a reason for hiding this comment

OddBloke commented Mar 13, 2020

goneri commented Mar 23, 2020

OddBloke left a comment

Choose a reason for hiding this comment

OddBloke Mar 24, 2020

Choose a reason for hiding this comment

OddBloke left a comment

Choose a reason for hiding this comment

OddBloke left a comment

Choose a reason for hiding this comment

OddBloke left a comment

Choose a reason for hiding this comment

raharper left a comment

Choose a reason for hiding this comment

raharper left a comment

Choose a reason for hiding this comment

raharper left a comment

Choose a reason for hiding this comment