New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-config: honor cloud_dir setting #1523
Conversation
@aciba90 , I noticed that this PR is in draft state. Is it still in progress, or is it ready for review? |
Yes, it is, @TheRealFalcon. I want to run the new integration test on Azure. I will let you know when ready, thanks. |
I have tested the added integration test on Azure, and added the Azure mark to execute it there too. This PR is ready to be reviewed @TheRealFalcon, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here! I left a few comments inline, but nothing major.
- Move integration test to meaningful file and allow it to run in every cloud - DataSourceBigstep: remove caching
Thanks a lot, @TheRealFalcon! I have addressed your comments / suggestions and this PR is ready to be reviewed after the build passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A new attribute was added to DataSourceAzure[1]. Since the base class uses CloudInitPickleMixin, we need to define this new attribute in _unpickle() Add multiple tests to improve pickle coverage. [1] #1523
A new attribute was added to DataSourceAzure[1]. Since the base class uses CloudInitPickleMixin, we need to define this new attribute in _unpickle() Add multiple tests to improve pickle coverage. [1] canonical#1523
A new attribute was added to DataSourceAzure[1]. Since the base class uses CloudInitPickleMixin, we need to define this new attribute in _unpickle() Add multiple tests to improve pickle coverage. [1] canonical#1523
Proposed Commit Message
Additional Context
https://bugs.launchpad.net/cloud-init/+bug/1976564
https://warthogs.atlassian.net/browse/SC-1085
Test Steps
Checklist: