net/dhcp: add udhcpc support #2125
Conversation
The currently used dhcp client, dhclient, is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022. This change introduce support for the dhcp client, udhcpc, sourced from the busybox project. Busybox advantages are that it is available across many distributions and comes with lightweight executables.
Cloud-init use as dhcp client, dhclient, which is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022. dhclient is deprecated in nixos Add patch to use `udhcpc` dhcp client coming from busybox instead. PR based on NixOS#226173 refs NixOS#215571 upstream PR: canonical/cloud-init#2125
Cloud-init use as dhcp client, dhclient, which is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022. dhclient is deprecated in nixos Add patch to use `udhcpc` dhcp client coming from busybox instead. PR based on NixOS#226173 refs NixOS#215571 upstream PR: canonical/cloud-init#2125
Cloud-init use as dhcp client, dhclient, which is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022. dhclient is deprecated in nixos Add patch to use `udhcpc` dhcp client coming from busybox instead. PR based on NixOS#226173 refs NixOS#215571 upstream PR: canonical/cloud-init#2125
There was a problem hiding this comment.
Thanks for this submission @jfroche, and for signing the CLA. I'll make sure to drop a comment here once PR: #2122 is resolved so that this can be refactored.
I haven't tested this, but it looks like a step in the right direction.
In the meantime, I'll note that this handles the most common dhclient case, however there are a couple of other (albeit datasource specific) dhclient requirements in the codebase that are missing from this PR.
* cloud-init: 22.4 -> 23.1.1 * cloud-init: add udhcpc support Cloud-init use as dhcp client, dhclient, which is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022. dhclient is deprecated in nixos Add patch to use `udhcpc` dhcp client coming from busybox instead. PR based on #226173 refs #215571 upstream PR: canonical/cloud-init#2125
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
github-actions
bot
added
the
stale-pr
@holmanb Should I rebase now that #2122 has been merged ?
I am interested to know what kind of extra dhcp features do we rely on ? Do you have some pointers ? Also can you remove the stale status ? Thank you ! |
|
Yes
A couple of specific features include parsing options parsing for Azure, and InfinBand support via dhcp-client-identifier. To ensure that parity with isc-dhcp-client is achieved, implementing all of the same methods that
No problem, done. |
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
github-actions
bot
added
the
stale-pr
TheRealFalcon
removed
the
stale-pr
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
github-actions
bot
added
the
stale-pr
The currently used dhcp client, dhclient, is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022.
This change introduce support for the dhcp client, udhcpc, from the busybox project. Busybox advantages are that it is available across many distributions and comes with lightweight executables.
It might be useful to rebase this PR once #2122 is merged.
Checklist: