Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lucasmoura as contributor #345

Merged
merged 2 commits into from May 4, 2020

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented May 4, 2020

Add lucasmoura as contributor in the project

@lucasmoura lucasmoura changed the title Add lucasmoura as author Add lucasmoura as contributor May 4, 2020
@@ -2,3 +2,4 @@ beezly
dhensby
nishigori
TheRealFalcon
lucasmoura
Copy link
Collaborator

@OddBloke OddBloke May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this list sorted. Perhaps we also need a doc update to instruct people to do that?

Copy link
Contributor Author

@lucasmoura lucasmoura May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update the documentation as well. Is there a good place to put that information ?

Copy link
Contributor Author

@lucasmoura lucasmoura May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, for this particular instance, should I do an amend to the original commit or create new a one sorting the list ?

Copy link
Collaborator

@OddBloke OddBloke May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we're missing docs for this ATM, so there aren't any to update. I've been meaning to add this, and briefly forgot that I hadn't yet. Apologies!

Copy link
Collaborator

@OddBloke OddBloke May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, for this particular instance, should I do an amend to the original commit or create new a one sorting the list ?

Good question! We squash-merge everything in cloud-init (and curtin, for that matter), so either will result in exactly the same commit on master. :-)

Copy link
Contributor Author

@lucasmoura lucasmoura May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OddBloke Done, I have sorted the list. Also, if you want I can work on that documentation

Copy link
Collaborator

@OddBloke OddBloke May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is going to require reworking/reorganising some existing docs, so it's probably not a great first week task, but thank you for the offer!

Copy link
Collaborator

@OddBloke OddBloke left a comment

Thanks!

@OddBloke OddBloke merged commit 59dd290 into canonical:master May 4, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants