Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #184

Merged
merged 2 commits into from Jan 28, 2023
Merged

Update docs #184

merged 2 commits into from Jan 28, 2023

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jan 27, 2023 •
edited

Issue

  1. Docs are outdated.
  2. Currently, the grafana-k8s docs on charmhub have "Overview" (the README from this repo) and "Docs" (an exact duplicate of the README).

Solution

Update docs.
The discourse doc can be deleted.

Fixes #169.

Release Notes

Update docs.

@sed-i sed-i marked this pull request as ready for review January 27, 2023 18:20
Abuelodelanada
Abuelodelanada approved these changes Jan 27, 2023
View reviewed changes
README.md Show resolved Hide resolved
rbarry82
rbarry82 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@rbarry82 rbarry82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sed-i sed-i merged commit 0a4430d into main Jan 28, 2023
@sed-i sed-i deleted the feature/doc-fix branch January 28, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

@rbarry82 rbarry82 rbarry82 approved these changes

@lucabello lucabello Awaiting requested review from lucabello lucabello is a code owner

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti PietroPasotti is a code owner

@dstathis dstathis Awaiting requested review from dstathis dstathis is a code owner

@simskij simskij Awaiting requested review from simskij simskij is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The readme is not consistent with the actual usage
3 participants
@sed-i @Abuelodelanada @rbarry82