Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #80

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Fix tests #80

merged 11 commits into from
Aug 20, 2024

Conversation

jpm-canonical
Copy link
Contributor

@jpm-canonical jpm-canonical commented Aug 12, 2024 •
edited
Loading

Summary

Solves:

Changes:

  • Update matter-snap-testing to beta.7. This solved the error we encountered.
  • Update tests to work with latest matter-snap-testing.
  • Rework logging, using test name in file name.
  • Update readme to use correct environment variable names.
  • Allow configuring local and remote Thread radio URLs.

Testing Steps

Local tests: passing
Thread tests: passing
GH workflow: passing

@jpm-canonical
Copy link
Contributor Author

jpm-canonical commented Aug 12, 2024 •
edited
Loading

Would be nice if we can get canonical/matter-snap-testing#34 merged first. Then we can bump the dependency, and add log dumping for gpio_mock.

Done.

@jpm-canonical jpm-canonical marked this pull request as ready for review August 12, 2024 14:08
farshidtz
farshidtz requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've done a first round of review. Good refactorings, but I have a few concerns with the changes.

tests/thread_tests/local.go Outdated Show resolved Hide resolved
tests/thread_tests/local.go Outdated Show resolved Hide resolved
tests/thread_tests/local.go Outdated Show resolved Hide resolved
tests/snap_test.go Show resolved Hide resolved
tests/snap_test.go Outdated Show resolved Hide resolved
tests/snap_test.go Outdated Show resolved Hide resolved
tests/snap_test.go Outdated Show resolved Hide resolved
tests/snap_test.go Outdated Show resolved Hide resolved
tests/snap_test.go Outdated Show resolved Hide resolved
tests/snap_test.go Show resolved Hide resolved
@jpm-canonical
Review comments
f18e80e 
Add missing error checks
farshidtz
farshidtz approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@farshidtz farshidtz merged commit 9c46e2a into main Aug 20, 2024
3 checks passed
@farshidtz farshidtz deleted the IENG-1154-fix-test branch August 20, 2024 11:23
@farshidtz farshidtz mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farshidtz farshidtz farshidtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpm-canonical @farshidtz