MicroCeph Remote Replication (1/3): Remote Awareness#405
Merged
Conversation
sabaini
requested changes
Aug 27, 2024
sabaini
left a comment
Collaborator
There was a problem hiding this comment.
Hey @UtkarshBhatthere thanks for the massive work. I've left some comments inline
3a2b4e7 to
9d63b6f
Compare
sabaini
requested changes
Sep 4, 2024
sabaini
left a comment
Collaborator
There was a problem hiding this comment.
Heya @UtkarshBhatthere , thanks!
I've added some comments/requests for doc, also a question wrt to privileges
bfa4839 to
52b2664
Compare
sabaini
requested changes
Sep 12, 2024
sabaini
left a comment
Collaborator
There was a problem hiding this comment.
Hey @UtkarshBhatthere this looks great. I've added one small testing improvement suggestion but otherwise +1
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
8bd28a1 to
f179cea
Compare
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
5b11519 to
c311909
Compare
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
c311909 to
ea4e590
Compare
sabaini
reviewed
Sep 20, 2024
sabaini
approved these changes
Sep 20, 2024
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
lmlg
reviewed
Sep 23, 2024
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
lmlg
approved these changes
Sep 27, 2024
lmlg
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thanks for addressing the comments
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
0b155b7 to
4dedea3
Compare
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the "Making MicroCeph aware of remote cluster" segment of Remote Replication requirement.
It includes:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Contributor's Checklist
Please check that you have: