Skip to content

MicroCeph Remote Replication (1/3): Remote Awareness#405

Merged
UtkarshBhatthere merged 27 commits into
mainfrom
feature/clusterExIm
Oct 1, 2024
Merged

MicroCeph Remote Replication (1/3): Remote Awareness#405
UtkarshBhatthere merged 27 commits into
mainfrom
feature/clusterExIm

Conversation

@UtkarshBhatthere

@UtkarshBhatthere UtkarshBhatthere commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Description

This PR implements the "Making MicroCeph aware of remote cluster" segment of Remote Replication requirement.
It includes:

  1. Cluster Export: Command/API to export ceph cluster state.
  2. Remote Import: Command/API to import a remote MicroCeph cluster in MicroCeph.
  3. Remote List: Command/API to list all remotes configured on the cluster.
  4. Remotes Table: To persist localCluster-remoteCluster pair in Dqlite.
  5. RBD-Mirror: Daemon enablement using service placement interface.
  6. Tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CleanCode (Code refactor, test updates, does not introduce functional changes)
  • Documentation update (Doc only change)

How Has This Been Tested?

  • Add CI tests

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

@sabaini sabaini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @UtkarshBhatthere thanks for the massive work. I've left some comments inline

Comment thread microceph/api/cluster.go Outdated
Comment thread microceph/api/remote.go Outdated
Comment thread microceph/api/remote.go Outdated
Comment thread microceph/ceph/services_placement_generic.go Outdated
Comment thread microceph/ceph/keyring.go Outdated
Comment thread microceph/cmd/microceph/enable_rbd_mirror.go Outdated
Comment thread microceph/cmd/microceph/remote_import.go Outdated
Comment thread microceph/api/types/remote.go
Comment thread microceph/client/cluster.go Outdated
Comment thread microceph/cmd/microceph/cluster_export.go Outdated
@UtkarshBhatthere UtkarshBhatthere changed the title Feature/cluster ex im MicroCeph Remote Replication (1/3): Remote CRUD Aug 27, 2024
@UtkarshBhatthere UtkarshBhatthere changed the title MicroCeph Remote Replication (1/3): Remote CRUD MicroCeph Remote Replication (1/3): Remote Awareness Sep 3, 2024

@sabaini sabaini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @UtkarshBhatthere , thanks!
I've added some comments/requests for doc, also a question wrt to privileges

Comment thread microceph/api/cluster.go Outdated
Comment thread microceph/api/cluster.go
Comment thread microceph/api/remote.go Outdated
Comment thread microceph/api/remote.go Outdated
Comment thread microceph/api/remote.go Outdated
Comment thread microceph/client/remote.go Outdated
Comment thread microceph/client/remote.go Outdated
Comment thread microceph/cmd/microceph/cluster_export.go Outdated
Comment thread microceph/cmd/microceph/remote_remove.go Outdated
Comment thread tests/scripts/actionutils.sh Outdated

@sabaini sabaini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @UtkarshBhatthere this looks great. I've added one small testing improvement suggestion but otherwise +1

Comment thread tests/scripts/actionutils.sh Outdated
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
@UtkarshBhatthere UtkarshBhatthere force-pushed the feature/clusterExIm branch 5 times, most recently from 5b11519 to c311909 Compare September 19, 2024 10:14
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Comment thread .github/workflows/tests.yml Outdated
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>

@lmlg lmlg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple nits.

Comment thread microceph/api/cluster.go Outdated
Comment thread microceph/api/remote.go
Comment thread microceph/ceph/keyring.go
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>

@lmlg lmlg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing the comments

Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
@UtkarshBhatthere UtkarshBhatthere merged commit 8572218 into main Oct 1, 2024
@UtkarshBhatthere UtkarshBhatthere deleted the feature/clusterExIm branch June 17, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants