Adds support for RO cluster configs#430
Merged
UtkarshBhatthere merged 1 commit intocanonical:mainfrom Oct 3, 2024
Merged
Conversation
UtkarshBhatthere
force-pushed
the
feature/ROClusterConfigs
branch
2 times, most recently
from
f2b79d5 to
8311f9e
Compare
sabaini
requested changes
Oct 1, 2024
Collaborator
sabaini
left a comment
sabaini
left a comment
There was a problem hiding this comment.
Heya @UtkarshBhatthere, lgtm in general -- one change request wrt to func signatures
cheers!
Also exposes public_network as a RO config. Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
UtkarshBhatthere
force-pushed
the
feature/ROClusterConfigs
branch
from
8311f9e to
7b2d224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for RO cluster configs and exposes public_network as a RO config.
Fixes #353
Type of change
How Has This Been Tested?
Please describe the addition/modification of tests done to verify this change. Please also list any relevant details for your test configuration.
Contributor's Checklist
Please check that you have: