Skip to content

Conversation

@boltmark
Copy link
Contributor

@boltmark boltmark commented Oct 1, 2024

Small PR which adds square brackets around mon host addresses in ceph.conf if IPv6 is used.

Closes #424.

@boltmark boltmark force-pushed the ipv6-square-brackets branch from 4a69377 to cb7a3a6 Compare October 1, 2024 04:33
Copy link
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @boltmark , thanks for this PR! One comment inline.

Also, would you be able to add some tests around this so we can be confident the change addresses the issue?

@boltmark boltmark force-pushed the ipv6-square-brackets branch from cb7a3a6 to 4f2d140 Compare October 1, 2024 23:34
@boltmark boltmark force-pushed the ipv6-square-brackets branch 2 times, most recently from 377a736 to 327da14 Compare October 4, 2024 22:16
@boltmark boltmark force-pushed the ipv6-square-brackets branch 4 times, most recently from b7759b7 to 60a1a9e Compare October 9, 2024 00:22
Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
@boltmark boltmark force-pushed the ipv6-square-brackets branch 3 times, most recently from 99f448f to add8819 Compare October 9, 2024 17:51
Signed-off-by: Mark Bolton <mark.bolton@canonical.com>
@boltmark boltmark force-pushed the ipv6-square-brackets branch from add8819 to 9a35f11 Compare October 9, 2024 18:05
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this

@UtkarshBhatthere UtkarshBhatthere merged commit c76c1f5 into canonical:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Square brackets around IPv6 addresses in ceph.conf

4 participants