MicroCeph Remote Replication (2/3): RBD Mirroring

[UtkarshBhatthere]

Description

Adds implementation for enabling/disabling rbd mirroring (remote replication) to a configured MicroCeph remote cluster.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• CleanCode (Code refactor, test updates, does not introduce functional changes)
• Documentation update (Contains Doc change)

How Has This Been Tested?

• CI Tests
• Unit Tests

Contributor's Checklist

Please check that you have:

• self-reviewed the code in this PR.
• added code comments, particularly in hard-to-understand areas.
• updated the user documentation with corresponding changes.
• added tests to verify effectiveness of this change.

[sabaini]

Hey @UtkarshBhatthere quite a bit of work here 🙇‍♂️
As a first pass I've added some doc suggestions and thoughts on API. -- sorry for harping on APIs but as these are cumbersome to change once released I feel spending extra time on them is worthwhile 😊

[sabaini]

Hi @UtkarshBhatthere thanks for the massive work!

I've added some suggestions, mostly around docs and logging, but otherwise lgtm!

[sabaini]

Hey @UtkarshBhatthere thanks for the additions,

Wrt to log messages, one thing I find valuable for troubleshooting is adding log messages that make it clear where in the code a fault occured. As Go does not log tracebacks automatically, it can be non-obvious where in a program a fault occured. Explicit log messages help with this issue.

cheers!