MicroCeph Remote Replication (3/3): Site Failover/Failback #438
Merged
UtkarshBhatthere merged 3 commits intoOct 21, 2024
Conversation
ab93da0 to
94ae9b5
Compare
sabaini
reviewed
Oct 15, 2024
sabaini
left a comment
Collaborator
There was a problem hiding this comment.
Hey @UtkarshBhatthere as discussed took a quick look at your last commit and left some comments.
39451a6 to
108a5c7
Compare
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
108a5c7 to
649ae0b
Compare
sabaini
approved these changes
Oct 21, 2024
sabaini
left a comment
Collaborator
There was a problem hiding this comment.
Hey @UtkarshBhatthere thanks, lgtm!
Two minor things that caught my eye but nothing to block over!
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change contains feature work to perform promotion/demotion for ALL pools across the cluster.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Documentation
Please check that you have: