Skip to content

MicroCeph Remote Replication (3/3): Site Failover/Failback #438

Merged
UtkarshBhatthere merged 3 commits into
canonical:mainfrom
UtkarshBhatthere:feature/failoverback
Oct 21, 2024
Merged

MicroCeph Remote Replication (3/3): Site Failover/Failback #438
UtkarshBhatthere merged 3 commits into
canonical:mainfrom
UtkarshBhatthere:feature/failoverback

Conversation

@UtkarshBhatthere

@UtkarshBhatthere UtkarshBhatthere commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Description

This change contains feature work to perform promotion/demotion for ALL pools across the cluster.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CleanCode (Code refactor, test updates, does not introduce functional changes)
  • Documentation update (Doc only change)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

  • Add Functional Tests
  • Add Unit Tests

Documentation

  • Add command references
  • Add a How-To

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

@UtkarshBhatthere UtkarshBhatthere force-pushed the feature/failoverback branch 10 times, most recently from ab93da0 to 94ae9b5 Compare October 14, 2024 10:21

@sabaini sabaini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @UtkarshBhatthere as discussed took a quick look at your last commit and left some comments.

Comment thread docs/how-to/perform-site-failover.rst
Comment thread microceph/api/ops_replication.go Outdated
Comment thread microceph/ceph/rbd_mirror.go Outdated
Comment thread microceph/ceph/rbd_mirror.go
Comment thread microceph/ceph/replication.go
Comment thread microceph/ceph/replication_rbd.go Outdated
@UtkarshBhatthere UtkarshBhatthere force-pushed the feature/failoverback branch 14 times, most recently from 39451a6 to 108a5c7 Compare October 20, 2024 19:48
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>

@sabaini sabaini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @UtkarshBhatthere thanks, lgtm!
Two minor things that caught my eye but nothing to block over!

Comment thread microceph/api/ops_replication.go Outdated
Comment thread microceph/api/ops_replication.go Outdated
Signed-off-by: Utkarsh Bhatt <utkarsh.bhatt@canonical.com>
@UtkarshBhatthere UtkarshBhatthere merged commit 2dd856d into canonical:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants