Pin LXD and use microcluster with dqlite LTS#454
Merged
sabaini merged 2 commits intocanonical:mainfrom Nov 7, 2024
Merged
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Contributor
Author
|
Should I open this PR against another LTS branch (I can only see |
Collaborator
|
Thank you @roosterfish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin LXD
When defining the microcluster API handlers you have to import from
"github.com/canonical/lxd/lxd/response"for the handlers return value.As this dependency can diverge from the same import that microcluster users internally, you might end up with build issues if you don't use the same version as microcluster.
We have already filed an improvement in microcluster to address this in future releases.
But for now pinning down the version is a good measure to prevent build errors in the future during maintenance of the LTS.
The same measure is applied in microcluster to ensure every downstream can stay on track with the used version of LXD.
See this PR for the same change in MicroCloud and this PR for MicroOVN.
Dqlite LTS
In addition microcluster is updated to
v2.0.5which uses dqlitev2LTS.