Skip to content

Make remote replication CLI conformant to CLI guidelines#456

Merged
sabaini merged 5 commits intomainfrom
fix/dropRemoteFromCli
Nov 8, 2024
Merged

Make remote replication CLI conformant to CLI guidelines#456
sabaini merged 5 commits intomainfrom
fix/dropRemoteFromCli

Conversation

@UtkarshBhatthere
Copy link
Copy Markdown
Contributor

@UtkarshBhatthere UtkarshBhatthere commented Nov 7, 2024

Description

Modify remote replication CLI to replication CLI.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CleanCode (Code refactor, test updates, does not introduce functional changes)
  • Documentation update (Doc only change)

How Has This Been Tested?

Using CI

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • modified tests to verify effectiveness of this change.

Signed-off-by: utkarsh bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: utkarsh bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: utkarsh bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: utkarsh bhatt <utkarsh.bhatt@canonical.com>
Signed-off-by: utkarsh bhatt <utkarsh.bhatt@canonical.com>
@UtkarshBhatthere UtkarshBhatthere changed the title Dropped remote from remote replication CLI Make remote replication CLI conformant to CLI guidelines Nov 8, 2024
Copy link
Copy Markdown
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sabaini sabaini merged commit ad8b261 into main Nov 8, 2024
@UtkarshBhatthere UtkarshBhatthere deleted the fix/dropRemoteFromCli branch June 17, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants