Skip to content

Improve require-osd-release #460

Merged
lmlg merged 1 commit into
osd-set-releasefrom
update-osd-release-patch
Nov 11, 2024
Merged

Improve require-osd-release #460
lmlg merged 1 commit into
osd-set-releasefrom
update-osd-release-patch

Conversation

@sabaini
Copy link
Copy Markdown
Collaborator

@sabaini sabaini commented Nov 11, 2024

No description provided.

@sabaini sabaini force-pushed the update-osd-release-patch branch from 4913a07 to 2974bbf Compare November 11, 2024 12:31
Copy link
Copy Markdown
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a nit.

Also some addtl tests

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
@sabaini sabaini force-pushed the update-osd-release-patch branch from 2974bbf to 607c81d Compare November 11, 2024 14:14
Copy link
Copy Markdown
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmlg lmlg merged commit 98578f7 into osd-set-release Nov 11, 2024
@UtkarshBhatthere UtkarshBhatthere deleted the update-osd-release-patch branch June 17, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants