Skip to content

Test: add reef to squid upgrade test#461

Merged
lmlg merged 1 commit intocanonical:mainfrom
sabaini:test/r2s-upgrade
Nov 11, 2024
Merged

Test: add reef to squid upgrade test#461
lmlg merged 1 commit intocanonical:mainfrom
sabaini:test/r2s-upgrade

Conversation

@sabaini
Copy link
Copy Markdown
Collaborator

@sabaini sabaini commented Nov 11, 2024

Description

Add upgrade test

Type of change

Please delete options that are not relevant.

  • CleanCode (Code refactor, test updates, does not introduce functional changes)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

Please describe the addition/modification of tests done to verify this change. Please also list any relevant details for your test configuration.

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

Signed-off-by: Peter Sabaini <peter.sabaini@canonical.com>
@lmlg
Copy link
Copy Markdown
Contributor

lmlg commented Nov 11, 2024

Does it make sense to check that the osd-release is now properly set (and thus no warnings appear on a call to ceph status) ?

@lmlg
Copy link
Copy Markdown
Contributor

lmlg commented Nov 11, 2024

Does it make sense to check that the osd-release is now properly set (and thus no warnings appear on a call to ceph status) ?

Disregard, this has been merged in a separate PR.

Copy link
Copy Markdown
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great stuff.

@lmlg lmlg merged commit 4e13724 into canonical:main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants