Do not try to match/rename duplicated MAC of vlan (LP: #1888726)

[slyon]

Description

Fix systemd-networkd misconfiguration; when matching on macaddr, if other interfaces in the system might have the same mac (e.g. bridge, vlan, etc), the match filtering must also filter which interface to match, e.g., besides the MACAddress= match it also needs (for example) one or more of:

• Type=!vlan
• Type=!bridge

PS: also cleaning up the test_vlans.py file a bit, while working on it.

Checklist

• Runs make check successfully.
• Retains 100% code coverage (make check-coverage).
• New/changed keys in YAML format are documented.
• (Optional) Adds example YAML for new feature.
• (Optional) Closes an open bug in Launchpad: https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/1888726

[slyon]

Integration tests all passed.

[codecov-io]

Codecov Report

Merging #166 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          48       48           
  Lines        6729     6737    +8     
=======================================
+ Hits         6654     6662    +8     
  Misses         75       75           

Impacted Files	Coverage Δ
src/networkd.c	100.00% <100.00%> (ø)
tests/generator/base.py	100.00% <100.00%> (ø)
tests/generator/test_vlans.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcb3d4...00ab717. Read the comment docs.

[sil2100]

Looking at it today!

[sil2100]

Looks good, thank you for this! Guess we forgot about that list there.