Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify requirements for a link local route #226

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

kjetilho
Copy link
Contributor

@kjetilho kjetilho commented Aug 30, 2021

Description

This gives a better hint on how to add a link local route. Ie., if the user tries to add a local route (without a gateway (via)), they will get an error message that a global route needs via, and hopefully understand they should use scope: local. Also, the docs spell this out.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

Copy link
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I recall having a discussion on IRC on this particular point last week, which indicates a clear need ;-)

doc/netplan.md Outdated Show resolved Hide resolved
kjetilho and others added 2 commits September 4, 2021 13:24
Co-authored-by: Simon Chopin <87005181+schopin-pro@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #226 (fe54301) into main (c6613b5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          56       56           
  Lines        9343     9343           
=======================================
  Hits         9252     9252           
  Misses         91       91           
Impacted Files Coverage Δ
src/parse.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6613b5...fe54301. Read the comment docs.

Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying this bit of our documentation! LGTM as well!

@slyon slyon merged commit e533ddf into canonical:main Sep 7, 2021
@slyon slyon added documentation Documentation improvements. community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants