generate:dbus:util: glib 2.70 compat#235
Merged
Merged
Conversation
slyon
force-pushed
the
slyon/glib2.70-fixes
branch
from
7510df6 to
b07c41c
Compare
g_spawn_check_exit_status is deprecated since libglib 2.70 and replaced by g_spawn_check_wait_status
slyon
force-pushed
the
slyon/glib2.70-fixes
branch
from
b07c41c to
ac35cb8
Compare
schopin-pro
approved these changes
Nov 22, 2021
Contributor
schopin-pro
left a comment
schopin-pro
left a comment
There was a problem hiding this comment.
LGTM, make check passed both on Impish and Jammy-proposed (with glib 2.70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
g_spawn_check_exit_status()is deprecated since libglib 2.70 and replaced byg_spawn_check_wait_status()https://docs.gtk.org/glib/func.spawn_check_wait_status.html
Checklist
make checksuccessfully.make check-coverage).