Skip to content

generate:dbus:util: glib 2.70 compat #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Oct 1, 2021

Description

g_spawn_check_exit_status() is deprecated since libglib 2.70 and replaced by g_spawn_check_wait_status()

https://docs.gtk.org/glib/func.spawn_check_wait_status.html

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon requested a review from schopin-pro November 4, 2021 12:34
@slyon slyon force-pushed the slyon/glib2.70-fixes branch from 7510df6 to b07c41c Compare November 4, 2021 12:35
slyon added 2 commits November 4, 2021 16:57
g_spawn_check_exit_status is deprecated since libglib 2.70 and replaced
by g_spawn_check_wait_status
@slyon slyon force-pushed the slyon/glib2.70-fixes branch from b07c41c to ac35cb8 Compare November 4, 2021 15:57
Copy link
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make check passed both on Impish and Jammy-proposed (with glib 2.70)

@schopin-pro schopin-pro merged commit 15c98fe into main Nov 22, 2021
@slyon slyon deleted the slyon/glib2.70-fixes branch November 14, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants