-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyfile: do not try to write out unvalidated YAML (LP: #1952967) #247
Conversation
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 58 58
Lines 10038 10052 +14
=======================================
+ Hits 9948 9962 +14
Misses 90 90
Continue to review full report at Codecov.
|
7cbab24
to
008fdd2
Compare
…ue to missing fields Fall back to using full passthrough mode ('nm-devices:') for now.
return FALSE and fill the passed GError if it does not succeed
008fdd2
to
ad389f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I wouldn't have expected this many different changes from the PR description. But then, who am I to talk 😉
There's only a small nitpick, but you can disregard it and merge if you feel like it.
Co-authored-by: Simon Chopin <simon.chopin@canonical.com>
Description
netplan's keyfile parser can handle certain device types and settings from NM's keyfile format. But we should try to avoid writing out partial YAML where some (essential) fields are missing, as they cannot (yet) be properly parsed.
We need to check that during testing and ideally also at runtime, in order to fall back to the full passthrough mode, using the generic
nm-devices
type.FR-1898
Checklist
make check
successfully.make check-coverage
).