Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve routing capabilities (LP: #1892272) (LP: #1805038) #248

Merged
merged 7 commits into from
Jan 11, 2022

Conversation

slyon
Copy link
Collaborator

@slyon slyon commented Dec 16, 2021

Description

  • Supporting additional route types: anycast, broadcast, local, multicast, nat, throw, xresolve (supported by systemd-networkd as of v243)
  • Not assuming a type: unicast, scope: global, by default, but making the default scope depend on the route type:
    • local -> host
    • nat -> host
    • broadcast -> link
    • multicast -> link
    • anycast -> link
    • unicast without gateway/via -> link
    • unicast with gateway/via -> global
    • global otherwise

This only affects the systemd-networkd backend renderer as for NetworkManager only "unicast" routes are supported.

FR-1798
FR-1078
FR-1077

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad. LP#1892272 & LP#1805038

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #248 (df2a5f2) into main (3e3c371) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          58       58           
  Lines       10055    10078   +23     
=======================================
+ Hits         9965     9988   +23     
  Misses         90       90           
Impacted Files Coverage Δ
tests/generator/test_errors.py 100.00% <ø> (ø)
src/parse.c 99.81% <100.00%> (+<0.01%) ⬆️
tests/generator/test_routing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3c371...df2a5f2. Read the comment docs.

src/parse.c Show resolved Hide resolved
@slyon slyon marked this pull request as ready for review January 5, 2022 11:58
@slyon slyon changed the title Improve routing capabilities Improve routing capabilities (LP: #1892272) (LP: #1805038) Jan 5, 2022
@slyon slyon requested a review from schopin-pro January 5, 2022 15:30
Copy link
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

src/parse.c Show resolved Hide resolved
@schopin-pro
Copy link
Contributor

Well, I'll let you rebase and merge is more like it, but still, nice work :)

@slyon slyon merged commit 095710a into main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants