YAML consolidation prelude: High-level libnetplan bindings (FR-702) #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 99.10% 99.11% +0.01%
==========================================
Files 58 60 +2
Lines 10078 10206 +128
==========================================
+ Hits 9988 10116 +128
Misses 90 90
Continue to review full report at Codecov.
|
5 tasks
schopin-pro
changed the title
5 tasks
slyon
reviewed
Jan 7, 2022
schopin-pro
force-pushed
the
yaml-consolidation-bindings-prelude
branch
4 times, most recently
from
60862fd
to
fc4b8fa
Compare
The utils module was getting kind of crowded.
We're using the iterator as the introduction point of the transition, but the idea is to use these classes as the main way to interact with the C library. Note the temporary GlobalState class that has been introduced as a temporary measure. It should be gone by the end of the patchset. :) V2: * rename struct devtype_def_iter to netdef_pertype_iter
Co-authored-by: Lukas Märdian <slyon@ubuntu.com>
schopin-pro
force-pushed
the
yaml-consolidation-bindings-prelude
branch
from
fc4b8fa
to
f55b847
Compare
2 tasks
slyon
approved these changes
Jan 13, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some high-level Python bindings. This is mostly a skeleton that will be populated with the needed elements in later PRs, which will remain in draft state until this one is merged.
Checklist
make checksuccessfully.make check-coverage).