nm:parse-nm: handle differing ip6-privacy default value#263
Merged
Conversation
Commit 64e381e (#244) changed netplan's behaviour to always write out the ipv6-privacy value (default to 0=off), in order to comply with what is written in our documentation and how it is implemented in the networkd backend. This is a problem for our NetworkManager integration, as NM's default value is -1=unknown. Netplan only supports values 0=off and 2=on while NM supports -1, 0, 1 and 2. We need to handle unsupported cases (-1 and 1) via passthrough.
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 61 61
Lines 10837 10860 +23
=======================================
+ Hits 10737 10760 +23
Misses 100 100
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit 64e381e (#244) changed netplan's
behaviour to always write out the ipv6-privacy value (default to 0=off),
in order to comply with what is written in our documentation and how it is
implemented in the networkd backend.
This is a problem for our NetworkManager integration, as NM's default value
is -1=unknown. Netplan only supports values 0=off and 2=on while NM supports
-1, 0, 1 and 2. We need to handle unsupported cases (-1 and 1) via passthrough.
Checklist
make checksuccessfully.make check-coverage).