Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: Update to latest version and resync with Fedora spec #264

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

Conan-Kudo
Copy link
Contributor

@Conan-Kudo Conan-Kudo commented Feb 20, 2022

Description

This makes the rpm packaging work with the latest versions of
Netplan and accounts for changes in the RH/Fedora ecosystem.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).

@Conan-Kudo Conan-Kudo force-pushed the update-rpmspec branch 2 times, most recently from 38dfed2 to 37b595c Compare February 20, 2022 14:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #264 (c3a87e1) into main (3e522b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          61       61           
  Lines       10860    10860           
=======================================
  Hits        10760    10760           
  Misses        100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e522b7...c3a87e1. Read the comment docs.

This makes the rpm packaging work with the latest versions of
Netplan and accounts for changes in the RH/Fedora ecosystem.

Signed-off-by: Neal Gompa <ngompa13@gmail.com>
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the RPM spec! LGTM

@slyon slyon merged commit aabfc26 into canonical:main Feb 22, 2022
@Conan-Kudo Conan-Kudo deleted the update-rpmspec branch February 22, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants