Skip to content

Fix infinite timeouts in ovs-vsctl (Closes: #1000137)#266

Merged
schopin-pro merged 2 commits into
mainfrom
slyon/ovs-timeout
May 11, 2022
Merged

Fix infinite timeouts in ovs-vsctl (Closes: #1000137)#266
schopin-pro merged 2 commits into
mainfrom
slyon/ovs-timeout

Conversation

@slyon
Copy link
Copy Markdown
Contributor

@slyon slyon commented Mar 3, 2022

Description

ovs-vsctl will hang forever if the host is not OVS enabled, blocking the tests. This can especially happen when running tests in a container where the host does not have OVS installed (e.g. ci.debian.net).

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Debian: https://bugs.debian.org/1000137

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #266 (a4ad684) into main (306600d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          61       61           
  Lines       10864    10864           
=======================================
  Hits        10764    10764           
  Misses        100      100           
Impacted Files Coverage Δ
tests/generator/base.py 100.00% <ø> (ø)
tests/generator/test_ovs.py 100.00% <ø> (ø)
src/openvswitch.c 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306600d...a4ad684. Read the comment docs.

@slyon slyon force-pushed the slyon/ovs-timeout branch from 1c82382 to a4ad684 Compare April 27, 2022 08:14
@slyon
Copy link
Copy Markdown
Contributor Author

slyon commented Apr 27, 2022

Things are starting to look good again on ci.debian.net/packages/n/netplan.io with Debian package 0.103-4 which contains this changeset as a distro-patch.

slyon added 2 commits April 27, 2022 10:30
ovs-vsctl will hang forever if the host is not OVS enabled, blocking the tests
@slyon slyon force-pushed the slyon/ovs-timeout branch from a4ad684 to 3af03ae Compare April 27, 2022 08:32
@slyon slyon marked this pull request as ready for review April 27, 2022 08:32
@slyon slyon changed the title Fix infinite timeouts in ovs-vsctl Fix infinite timeouts in ovs-vsctl (Closes: #1000137) Apr 27, 2022
@schopin-pro schopin-pro self-requested a review May 9, 2022 16:00
Copy link
Copy Markdown
Contributor

@schopin-pro schopin-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging!

@schopin-pro schopin-pro merged commit 62f0a75 into main May 11, 2022
@schopin-pro schopin-pro deleted the slyon/ovs-timeout branch May 11, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants