dbus: Remove the upper limit on try timeout (LP: #1967084) #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, increase the default to 10s.
If the caller sees fit to specifiy a 30s timeout for their try call, it
stands to reason to respect that decision, as they (probably) know
better.
This issue came up in the Core testsuite, where the netplan
configuration step failed because
netplan try
took 6s, cfLP: #1967084. Their DBus call specifies a timeout of 300s, but the call
failed after a "relatively short time", which was this internal timeout.
Note that the mere fact that
netplan try
takes more than 5s on such asimple configuration is probably due to the following patch:
https://git.launchpad.net/ubuntu/+source/netplan.io/tree/debian/patches/0006-cli-apply-give-some-extra-time-for-networkctl-reload.patch?h=applied/ubuntu/focal-updates
Since the bridge is empty, it might be in a "configuring" state forever.
Granted, that's not something one would do on production systems,
however creating an empty bridge interface is routinely done in test
suites, including our own.
Checklist
make check
successfully.make check-coverage
).