cli: fix crash on LibNetplanException#286
Merged
Merged
Conversation
slyon
force-pushed
the
slyon/error.u.c-crash
branch
from
July 20, 2022 16:18
67e7413 to
a54f0a1
Compare
slyon
marked this pull request as ready for review
July 20, 2022 16:20
dbungert
reviewed
Jul 21, 2022
dbungert
left a comment
dbungert
left a comment
Member
There was a problem hiding this comment.
As this is my first view of the netplan code I'm not certain about the feedback, but I have a couple questions to consider.
Contributor
Author
|
Thanks for your feedback @dbungert! I think I addressed all of your comments. Is there anything to add from your side? IMO this is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catch exception on config error (
LibNetplanExceptionfrom the libnetplan YAML parser) to exit gracefully on error, without applying any configuration. Display the parsing error on stderr.As observed via https://errors.ubuntu.com/problem/2f11b72a6028059267c77dc94cfd3c4028cf58ac
Checklist
make checksuccessfully.make check-coverage).