apply: Fix crash when OVS is stopped (LP#1995598)#307
Merged
Conversation
If openvswitch is installed but not running, netplan apply will try to call the service anyway and will crash. In this case we probably should ignore the error and log a warning message to the user. Add an integration test that will be executed by autopkgtest.
slyon
reviewed
Jan 18, 2023
| from netplan.cli.utils import systemctl_is_active | ||
|
|
||
| OPENVSWITCH_OVS_VSCTL = '/usr/bin/ovs-vsctl' | ||
| OPENVSWITCH_OVSDB_SERVER_UNIT = 'ovsdb-server' |
Contributor
There was a problem hiding this comment.
Let's call it ovsdb-server.service explicitly
slyon
approved these changes
Jan 19, 2023
slyon
left a comment
Contributor
There was a problem hiding this comment.
Thanks, lgtm!
I added some small bit to call ovsdb-server.service by its explicit name (including the .service suffix). Let's merge it once it passes the tests.
|
This error is because ovsdb-server.service is not running, and if it is not running, you can install it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If openvswitch is installed but not running, netplan apply will try to call the service anyway and will crash. In this case we probably should ignore the error and log a warning message to the user.
Add an integration test that will be executed by autopkgtest.
Description
It addresses https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/1995598
The problem can be reproduced with:
Checklist
make checksuccessfully.make check-coverage).