Skip to content

tests: mock calls to systemctl#314

Merged
slyon merged 1 commit intocanonical:mainfrom
daniloegea:status_tests
Jan 18, 2023
Merged

tests: mock calls to systemctl#314
slyon merged 1 commit intocanonical:mainfrom
daniloegea:status_tests

Conversation

@daniloegea
Copy link
Copy Markdown
Contributor

Some tests were failing in sbuild due to calls to systemctl. It would check if networkd was running and try to start it. In my system the same happens except these tests get stuck asking for my password if I stop networkd.

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

Some tests were failing in sbuild due to calls to systemctl. It would
check if networkd was running and try to start it. In my system the same
happens except these tests get stuck asking for my password if I stop
networkd.
Copy link
Copy Markdown
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@slyon slyon merged commit cab830c into canonical:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants